-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing X-Pack repositories REST specs #65548
Add missing X-Pack repositories REST specs #65548
Conversation
Pinging @elastic/clients-team (Team:Clients) |
Pinging @elastic/es-core-infra (Team:Core/Infra) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
x-pack/plugin/src/test/resources/rest-api-spec/api/repositories.clear_metering_archive.json
Outdated
Show resolved
Hide resolved
@fcofdez this LGTM, mind giving this a quick look over since this is your new API? 👍 |
Jenkins run elasticsearch-ci/2 please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
6fc3e9e
to
a2f846b
Compare
A new experimental X-Pack API was added for repositories, but is missing a REST spec. The API was added in elastic#60371
a2f846b
to
00ba10e
Compare
Apologies @fcofdez, I've just noticed that I let this PR get stale. Since these still need to be added I have rebased them and updated them to include some of the latest spec fields such as |
No worries @stevejgordon :). |
* Add missing repositories API REST specs A new experimental X-Pack API was added for repositories, but is missing a REST spec. The API was added in elastic#60371 * Move this under the nodes namespace * Rename max_version_to_clear parameter * Update docs URL to use current
💚 Backport successful
|
* Add missing repositories API REST specs A new experimental X-Pack API was added for repositories, but is missing a REST spec. The API was added in #60371 * Move this under the nodes namespace * Rename max_version_to_clear parameter * Update docs URL to use current Co-authored-by: Steve Gordon <[email protected]>
* Add missing repositories API REST specs A new experimental X-Pack API was added for repositories, but is missing a REST spec. The API was added in elastic#60371 * Move this under the nodes namespace * Rename max_version_to_clear parameter * Update docs URL to use current
While working on the .NET client code-gen, I noticed that a new experimental X-Pack API was added for repositories in 7.10.0, but is missing a REST spec required for client code generation. This PR adds the specs for the two new endpoints.
API was added in #60371
Please let me know what (if anything) needs to happen to backport to 7.10 and 7.x?